Skip to content

Conversation

@nico-palmar
Copy link
Contributor

Added the zed-ros2-wrapper as a submodule in our repo.

Also updated the readme to include recursive subclone (ie clone the submodule automatically).

Im not sure if I need to add any other dependencies/checks here or if I need to add any of the packages to ci.yaml (I assume I dont but just checking)

@keyonjerome
Copy link
Contributor

Does this have to be a submodule rather than a normal package we clone along with the others, such as vectornav?

@nico-palmar
Copy link
Contributor Author

nico-palmar commented Feb 14, 2023

Does this have to be a submodule rather than a normal package we clone along with the others, such as vectornav?

Nope, ticket said submodule so I assumed you meant actual submodule. Changed it to just an upstream dependency - not sure if I need to add anything else. Lmk @keyonjerome

@keyonjerome
Copy link
Contributor

Thanks -- yeah the submodule part was just me not thinking. Definitely works better as an upstream dependency. Feel free to merge this into your branch and deal with the failing lint checks there.

@keyonjerome keyonjerome self-requested a review February 14, 2023 19:00
zed2_ros_wrapper:
type: git
url: https://github.com/stereolabs/zed-ros2-wrapper.git
version: master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like specifying a specific commit here instead of master such that our repo doesn't randomly break in the case that they change something on the stereolabs/zed-ros2-wrapper side.

Base automatically changed from user/nick-palmar/207/aruco_pose_detection to master September 7, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants