Skip to content

Conversation

jordan-palacios
Copy link
Member

Follow up on #2310.

Same concept and approach, only this time we add force and current interfaces.

As before, adding these two new interfaces is backwards compatible. If force and current interfaces are not available then the contents from this PR do nothing.

@jordan-palacios jordan-palacios changed the title Feat/force and current interfaces [Transmissions] Add force and current interfaces Sep 29, 2025
@jordan-palacios jordan-palacios changed the title [Transmissions] Add force and current interfaces [Transmissions] Add force and current interfaces Sep 29, 2025
@jordan-palacios jordan-palacios force-pushed the feat/force_and_current_interfaces branch from 3bd5b9d to d6a2549 Compare September 29, 2025 10:56
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 85.36585% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.42%. Comparing base (bb87986) to head (d6a2549).

Files with missing lines Patch % Lines
...ansmission_interface/differential_transmission.hpp 68.42% 9 Missing and 3 partials ⚠️
...ude/transmission_interface/simple_transmission.hpp 62.50% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
- Coverage   89.45%   89.42%   -0.03%     
==========================================
  Files         147      147              
  Lines       16636    16752     +116     
  Branches     1400     1408       +8     
==========================================
+ Hits        14881    14980      +99     
- Misses       1218     1227       +9     
- Partials      537      545       +8     
Flag Coverage Δ
unittests 89.42% <85.36%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface/test/differential_transmission_test.cpp 99.61% <100.00%> (+0.09%) ⬆️
...ission_interface/test/simple_transmission_test.cpp 100.00% <100.00%> (ø)
...ude/transmission_interface/simple_transmission.hpp 75.64% <62.50%> (-1.64%) ⬇️
...ansmission_interface/differential_transmission.hpp 77.65% <68.42%> (-2.91%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jordan-palacios jordan-palacios marked this pull request as ready for review September 29, 2025 12:02
Comment on lines +233 to +234
// testIdentityMap(transmission, input_value, HW_IF_CURRENT);
// testIdentityMap(transmission, input_value, HW_IF_ABSOLUTE_POSITION);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants