Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 27, 2025

Gives #2484 a possibility to fix with a parameter

In the 27th August, 2025 PMC meeting, it has been decided to maintain the current behavior, but have an way to the old behavior using a controller_manager parameter. As the main fix is regarding the safety concerns, multiple attendees agreed to keep the behavior, but add a parameter to opt-out of it


This is an automatic backport of pull request #2501 done by Mergify.

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.19%. Comparing base (332f48f) to head (14ad6ed).
⚠️ Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
hardware_interface/src/resource_manager.cpp 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2584      +/-   ##
==========================================
+ Coverage   89.07%   89.19%   +0.11%     
==========================================
  Files         148      148              
  Lines       16682    16729      +47     
  Branches     1406     1407       +1     
==========================================
+ Hits        14860    14921      +61     
+ Misses       1288     1272      -16     
- Partials      534      536       +2     
Flag Coverage Δ
unittests 89.19% <98.38%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 76.22% <100.00%> (+0.86%) ⬆️
...rdware_interface/types/resource_manager_params.hpp 100.00% <ø> (ø)
...t/test_resource_manager_prepare_perform_switch.cpp 100.00% <100.00%> (ø)
hardware_interface/src/resource_manager.cpp 75.75% <93.75%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

mergify bot commented Oct 3, 2025

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor?

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor merged commit 5a2dc8b into jazzy Oct 3, 2025
11 of 14 checks passed
@saikishor saikishor deleted the mergify/bp/jazzy/pr-2501 branch October 3, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants