-
Notifications
You must be signed in to change notification settings - Fork 364
Add controller dependency graph for ::AUTO switch mode #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikishor
wants to merge
29
commits into
ros-controls:master
Choose a base branch
from
pal-robotics-forks:add/controllers/dependency_graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add controller dependency graph for ::AUTO switch mode #2578
saikishor
wants to merge
29
commits into
ros-controls:master
from
pal-robotics-forks:add/controllers/dependency_graph
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeea81a
to
9c9ef20
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2578 +/- ##
==========================================
+ Coverage 89.31% 89.35% +0.04%
==========================================
Files 145 145
Lines 16541 16931 +390
Branches 1396 1426 +30
==========================================
+ Hits 14773 15129 +356
- Misses 1231 1249 +18
- Partials 537 553 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the things needed for the ::AUTO switch mode and addresses few other things.
With the ::AUTO switch mode, you can activate and deactivate the whole chain
Here, you can activate the whole chain, activating controller A alone and deactivate the whole chain deactivating the controller E
Here, you can activate the whole chain, activating controller A alone and deactivate the whole chain deactivating the controller E and C
Activating controller D will only activate D and E
Activating controller B will activate B, C, D and E