Skip to content

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Sep 19, 2025

I rewrote the GenericSystem to let the resource_manager handle the value storage. This enables now the support of other data_types than double.

Open question:

  • in which transition should the initial values be set? (now in on_activate). Earlier this was done only once in on_init, which means that it remained after lifecycle change of the component.

Other minimal behavior changes:

  • applies position_state_following_offset already to initial_values
  • applies mimic.offset only to position interface

The current version iterates over the member variables of the HardwareComponentInterface instead of preallocating the values beforehand. I benchmarked the execution time with a config of 230 interfaces, and it increased from 2us to only 5us. I think this is negligible.

Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 86.70520% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.36%. Comparing base (56fc052) to head (eda82f4).

Files with missing lines Patch % Lines
...e_interface/src/mock_components/generic_system.cpp 85.71% 14 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
+ Coverage   89.31%   89.36%   +0.05%     
==========================================
  Files         145      145              
  Lines       16541    16572      +31     
  Branches     1396     1384      -12     
==========================================
+ Hits        14773    14809      +36     
+ Misses       1231     1224       -7     
- Partials      537      539       +2     
Flag Coverage Δ
unittests 89.36% <86.70%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...terface/include/mock_components/generic_system.hpp 100.00% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 99.73% <100.00%> (+<0.01%) ⬆️
...e_interface/src/mock_components/generic_system.cpp 85.46% <85.71%> (+1.37%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as ready for review September 23, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant