check for state of the controller node before cleanup #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
livanov93,
mcbed and
peterdavidfagan
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 47.49% 47.45% -0.04%
==========================================
Files 41 41
Lines 3556 3561 +5
Branches 1938 1942 +4
==========================================
+ Hits 1689 1690 +1
- Misses 459 460 +1
- Partials 1408 1411 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
reviewed
Feb 2, 2024
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
destogl
added
backport-humble
|
@saikishor I tried to test the fix this morning but ran into the issue that the whole controller_manager crashes on my But I took a quick look at the changes you made and they look reasonable to me. |
bmagyar
approved these changes
Feb 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit 6f57faf) # Conflicts: # controller_manager/test/test_controller_manager_srvs.cpp
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit 6f57faf) # Conflicts: # controller_manager/test/test_controller_manager_srvs.cpp
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit 6f57faf) # Conflicts: # controller_manager/test/test_controller_manager_srvs.cpp
christophfroehlich
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit 6f57faf) # Conflicts: # controller_manager/test/test_controller_manager_srvs.cpp
bmagyar
pushed a commit
that referenced
this pull request
Apr 9, 2024
bmagyar
pushed a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1136
If a controller tries to do the cleanup from an unconfigured state, it prints the following error in the terminal