Skip to content

Update plips.md: be more precise about mentioning teams to submit a PLIP #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.0
Choose a base branch
from
Open

Update plips.md: be more precise about mentioning teams to submit a PLIP #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/contributing/core/plips.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,13 @@ You may revise your PLIP based on feedback.

If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team.


## Team approves proposal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an anchor.

Suggested change
## Team approves proposal
(team-approves-proposal-label)=
## Team approves proposal


After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone.
Every PLIP must be approved by the designated team.

You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team.
You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain.


Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts a later line at https://github.com/plone/documentation/pull/1972/files#diff-a26160e65b3eaac12980b0e79dbd62bda9260754c0be27cf10424261c219e2e5R114. Y'all need to make a decision on when a developer may start work on their PLIP. I'd update or delete the later line, as it subverts the process.

One sentence per line, please.

Suggested change
Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP.
Every PLIP must be approved by the designated team.
Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP.


## Implement your PLIP

Expand Down