Update plips.md: be more precise about mentioning teams to submit a PLIP #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepiercy
requested changes
Sep 17, 2025
| After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone. | ||
| Every PLIP must be approved by the designated team. | ||
|
|
||
| You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team. |
There was a problem hiding this comment.
Suggested change
| You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team. | |
| You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain. |
|
|
||
| You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team. | ||
|
|
||
| Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. |
There was a problem hiding this comment.
This contradicts a later line at https://github.com/plone/documentation/pull/1972/files#diff-a26160e65b3eaac12980b0e79dbd62bda9260754c0be27cf10424261c219e2e5R114. Y'all need to make a decision on when a developer may start work on their PLIP. I'd update or delete the later line, as it subverts the process.
One sentence per line, please.
Suggested change
| Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. | |
| Every PLIP must be approved by the designated team. | |
| Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. |
| If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team. | ||
|
|
||
|
|
||
| ## Team approves proposal |
There was a problem hiding this comment.
Let's add an anchor.
Suggested change
| ## Team approves proposal | |
| (team-approves-proposal-label)= | |
| ## Team approves proposal |
github-project-automation
bot
moved this from New
to In Progress
in Plone Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors
You must read and follow our First-time contributors.
Submit a pull request
Thank you for your contribution to the Plone Documentation.
Before submitting this pull request, please make sure you follow our guides:
Issue number
Description
Write a description of the fixes or improvements.
Add screenshots or links to a preview of the changes
📚 Documentation preview 📚: https://plone6--1972.org.readthedocs.build/