Skip to content

Conversation

SZhengP
Copy link

@SZhengP SZhengP commented Oct 4, 2025

Follows the same pattern as commit 984398c which fixed manifest.name and manifest.homePage linting to use dynamic org.

This allows custom pipelines with different organizations to pass the multiqc_config lint check without needing to add exceptions.

PR checklist

  • [ x] This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Follows the same pattern as commit 984398c
which fixed manifest.name and manifest.homePage linting to use dynamic org.

This allows custom pipelines with different organizations to pass the
multiqc_config lint check without needing to add exceptions.
@SZhengP SZhengP requested review from nf-core-bot and Copilot October 4, 2025 15:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the multiqc_config lint check to dynamically use the organization name from .nf-core.yml configuration instead of hardcoding "nf-core" in report comment URLs. This follows the same pattern established in commit 984398c which fixed similar issues for manifest.name and manifest.homePage linting.

  • Adds dynamic organization name resolution from .nf-core.yml template configuration
  • Updates both dev and release version report comment URL generation to use the dynamic org name
  • Allows custom pipelines with different organizations to pass the multiqc_config lint check

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SZhengP SZhengP requested a review from mashehu October 4, 2025 15:43
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.35%. Comparing base (4942d71) to head (d855b3e).
⚠️ Report is 3 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@SZhengP SZhengP merged commit f0e8b8d into dev Oct 6, 2025
116 checks passed
@SZhengP SZhengP deleted the fix/lint_multiqc_org branch October 6, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants