-
Notifications
You must be signed in to change notification settings - Fork 212
Fixe Issues/3735: Check for docker and docker daemon and fail before download #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
self.container_fetcher = None | ||
try: | ||
if self.container_system == "singularity": | ||
self.container_fetcher = SingularityFetcher( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the SingularityFetcher
raise a similar error?
self.container_fetcher = None | ||
except OSError as e: | ||
log.error(e) | ||
exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to raise a UserWarning
or LookupError
, we handle these in the commands. This should be updated in the nf_core/commands_pipelines.py
, you can look at other commands to see an example.
exit(1) | |
raise UserWarning |
Closes #3735
Also adds a
try...except
around the container_fetcher initialization, to fail gracefully but with a meaningful error message.PR checklist
CHANGELOG.md
is updateddocs
is updated