-
Notifications
You must be signed in to change notification settings - Fork 14
Tracking spatiotemporal and temporal information for processes #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
graph BT | ||
A{Process | ||
Annual Marathon} -->|rdf:type| B[Process<br>BFO_0000015] | ||
A -->|occurs at| C{Site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add numbers for relations
A -->|occurs at| C{Site | ||
Central Park, NYC} | ||
C -->|rdf:type| D[Site<br>BFO_0000029] | ||
A -->|occurs in| E{Spatiotemporal Region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
occupies spatiotemporal region
C -->|rdf:type| D[Site<br>BFO_0000029] | ||
A -->|occurs in| E{Spatiotemporal Region | ||
Marathon Event } | ||
E -->|rdf:type| F[Spatiotemporal Region<br>BFO_0000154] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong number for spatiotemporal region
graph BT |
Add identifiers for relations |
Change names for individuals to the previous version |
Change relations to "occupies spatiotemporal region" and "occupies temporal region" |
Change name of "Golden Gate park, San Francisco 1" to "Golden Gate Park, San Francisco during July 12-14" to indicate it is a spatiotemporal region, then change the type from "site" to "spatiotemporal region", change type of "Festival Weekend July 12-14 2024" to temporal region, take away number from the "festival weekend" name |
%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes classDef yellow fill:#ffe680,stroke:#000000 |
spatiotemporal region id, get rid of extra 1 |
fix id for temporal region |
%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes classDef yellow fill:#ffe680,stroke:#000000 |
@elenamiliv can you make sure that after updating your fork you put this in the right 101 directory? |
I think the image has to be added to the right folder, and also it's missing the image file. |
…rticipate in events.png
adding the graph
@@ -0,0 +1,20 @@ | |||
%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to new patterns, and add picture
@@ -0,0 +1,47 @@ | |||
flowchart BT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to cco whitepaper
@@ -0,0 +1,47 @@ | |||
flowchart BT | |||
Person1["Person1"] -- agent_in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agent in code is wrong
Edu1["Educational | ||
Organization 1"] -- participates_in | ||
BFO_0000056 --> Act1 | ||
Act1 -- occupies_temporal_region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
occupies temporal region code
BFO_000018 --> Interval1["Multi-year | ||
Temporal Interval 1"] | ||
Act1 -- has_process_part | ||
BFO_0000051 --> Grad1["Graduation Event 1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has process part code
BFO_0000112 --> Degree1["Degree1"] | ||
Grad1 -- occupies_temporal_region | ||
BFO_0000187 --> Day1["Day1"] | ||
Interval1 -- interval_finishes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interval finishes code
@@ -0,0 +1,47 @@ | |||
flowchart BT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add classes for temporal region/process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. In addition to Giacomo’s suggestions, here’s a few points:
-we should discuss in a meeting how to organize these files
-make sure each mermaid code file has a corresponding image
About the measurement Units image:
-The IDs for object properties and classes should be included
-the cco prefix shouldn’t be in front of the class
-replace ‘has part’ with ‘has continuant part’
-replace ‘carries’ with ‘is carrier of’
-the domain of both ‘uses measurement unit’ and ‘has text value’ is IBE. I don’t believe the Carbon Measurement is an IBE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This design pattern doesn't appear to match either of the code file submissions. And the code files are missing their accompanying design patterns. This pattern itself looks good, a few notes:
-be sure to include IDs for classes and relations.
-has part should be replaced with has continuant part
-replace carries with is carrier of
-include a parent class for carbon measurement
-remove 'Value' from the text value, it should just be '15.2'
Adding the design pattern
