Skip to content

Conversation

elenamiliv
Copy link
Contributor

Adding the design pattern
Untitled diagram-2024-12-17-145334

graph BT
A{Process
Annual Marathon} -->|rdf:type| B[Process<br>BFO_0000015]
A -->|occurs at| C{Site
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add numbers for relations

A -->|occurs at| C{Site
Central Park, NYC}
C -->|rdf:type| D[Site<br>BFO_0000029]
A -->|occurs in| E{Spatiotemporal Region
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

occupies spatiotemporal region

C -->|rdf:type| D[Site<br>BFO_0000029]
A -->|occurs in| E{Spatiotemporal Region
Marathon Event }
E -->|rdf:type| F[Spatiotemporal Region<br>BFO_0000154]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong number for spatiotemporal region

@elenamiliv
Copy link
Contributor Author

mermaid-diagram-2025-01-07-111516

@elenamiliv
Copy link
Contributor Author

graph BT
A{"Process
Annual Marathon"} --> |1rdf:type| B["Process
BFO_0000015"]
A --> |2 occurs at| C{"Site
Central Park, NYC"}
C --> |3rdf:type| D["Site
BFO_0000029"]
A --> |4 occupies| E{"Spatiotemporal_Region
Marathon Event"}
E --> |5rdf:type| F["Spatiotemporal Region BFO_0000011"]
classDef yellow fill:#ffe680,stroke:#000000
classDef purple fill:#dbc9ef,stroke:#000000,shape:diamond
class A,C,E purple
class B,D,F yellow

@giacomodecolle
Copy link
Owner

giacomodecolle commented Jan 7, 2025

Add identifiers for relations

@giacomodecolle
Copy link
Owner

Change names for individuals to the previous version

@giacomodecolle
Copy link
Owner

Go back to spatiotemporal and temporal region as per image
4940096C-F7B4-4EF5-B94F-19CD89D4B35C

@giacomodecolle
Copy link
Owner

Change relations to "occupies spatiotemporal region" and "occupies temporal region"

@elenamiliv
Copy link
Contributor Author

Untitled diagram-2025-01-14-133545

@giacomodecolle
Copy link
Owner

Change name of "Golden Gate park, San Francisco 1" to "Golden Gate Park, San Francisco during July 12-14" to indicate it is a spatiotemporal region, then change the type from "site" to "spatiotemporal region", change type of "Festival Weekend July 12-14 2024" to temporal region, take away number from the "festival weekend" name

@elenamiliv
Copy link
Contributor Author

Untitled diagram-2025-01-21-135015

%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes
graph BT
A{Music Festival
1} -->|rdf:type
| B[Process
BFO_0000015]
A -->|occupies_spatiotemporal_region
BFO_0000200| C{Golden Gate Park, San Francisco during July 12-14}
C -->|rdf:type
| D[Spatiotemporal_Region
BFO_0000111]
A -->|occupies_temporal_region
BFO_0000199| E{Festival Weekend July 12–14 2024}
E -->|rdf:type
| F[Temporal_Region BFO_0000199]

classDef yellow fill:#ffe680,stroke:#000000
classDef purple fill:#dbc9ef,stroke:#000000,shape:diamond
class A,C,E purple
class B,D,F yellow

@Finn1928
Copy link
Collaborator

spatiotemporal region id, get rid of extra 1

@Finn1928
Copy link
Collaborator

fix id for temporal region

@elenamiliv
Copy link
Contributor Author

mermaid-diagram-2025-01-28-091637

%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes
graph BT
A{Music Festival
1} -->|rdf:type
| B[Process
BFO_0000015]
A -->|occupies_spatiotemporal_region
BFO_0000200| C{Golden Gate Park, San Francisco during July 12-14}
C -->|rdf:type
| D[Spatiotemporal_Region
BFO_0000011]
A -->|occupies_temporal_region
BFO_0000199| E{Festival Weekend July 12–14 2024}
E -->|rdf:type
| F[Temporal_Region BFO_0000008]

classDef yellow fill:#ffe680,stroke:#000000
classDef purple fill:#dbc9ef,stroke:#000000,shape:diamond
class A,C,E purple
class B,D,F yellow

@giacomodecolle
Copy link
Owner

@elenamiliv can you make sure that after updating your fork you put this in the right 101 directory?

@Finn1928
Copy link
Collaborator

I think the image has to be added to the right folder, and also it's missing the image file.

@@ -0,0 +1,20 @@
%% Design Pattern: Tracking Spatiotemporal and Temporal Information for Processes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to new patterns, and add picture

@@ -0,0 +1,47 @@
flowchart BT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to cco whitepaper

@@ -0,0 +1,47 @@
flowchart BT
Person1["Person1"] -- agent_in
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agent in code is wrong

Edu1["Educational
Organization 1"] -- participates_in
BFO_0000056 --> Act1
Act1 -- occupies_temporal_region
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

occupies temporal region code

BFO_000018 --> Interval1["Multi-year
Temporal Interval 1"]
Act1 -- has_process_part
BFO_0000051 --> Grad1["Graduation Event 1"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has process part code

BFO_0000112 --> Degree1["Degree1"]
Grad1 -- occupies_temporal_region
BFO_0000187 --> Day1["Day1"]
Interval1 -- interval_finishes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interval finishes code

@@ -0,0 +1,47 @@
flowchart BT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add classes for temporal region/process

Copy link
Collaborator

@Finn1928 Finn1928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good. In addition to Giacomo’s suggestions, here’s a few points:
-we should discuss in a meeting how to organize these files
-make sure each mermaid code file has a corresponding image
About the measurement Units image:
-The IDs for object properties and classes should be included
-the cco prefix shouldn’t be in front of the class
-replace ‘has part’ with ‘has continuant part’
-replace ‘carries’ with ‘is carrier of’
-the domain of both ‘uses measurement unit’ and ‘has text value’ is IBE. I don’t believe the Carbon Measurement is an IBE

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design pattern doesn't appear to match either of the code file submissions. And the code files are missing their accompanying design patterns. This pattern itself looks good, a few notes:
-be sure to include IDs for classes and relations.
-has part should be replaced with has continuant part
-replace carries with is carrier of
-include a parent class for carbon measurement
-remove 'Value' from the text value, it should just be '15.2'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants