Skip to content

Revert ImageBasedFrame zoom change listener #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Revert ImageBasedFrame zoom change listener #3342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions bundles/org.eclipse.e4.ui.widgets/src/org/eclipse/e4/ui/widgets/ImageBasedFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
******************************************************************************/
package org.eclipse.e4.ui.widgets;

import java.util.concurrent.atomic.AtomicReference;

import org.eclipse.swt.SWT;
import org.eclipse.swt.events.ControlEvent;
import org.eclipse.swt.events.ControlListener;
Expand All @@ -26,8 +24,6 @@
import org.eclipse.swt.widgets.Canvas;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Listener;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.swt.widgets.ToolBar;


Expand Down Expand Up @@ -70,20 +66,12 @@ public ImageBasedFrame(Composite parent, Control toWrap, boolean vertical,
ImageBasedFrame frame = (ImageBasedFrame) event.widget;
frame.setCursor(null);
});

toWrap.addListener(SWT.ZoomChanged, event -> {
Shell shell = parent.getShell();
final AtomicReference<Listener> scaleOnParentResize = new AtomicReference<>();
scaleOnParentResize.set(e -> {
if (isDisposed()) {
return;
}
toWrap.pack(true);
setFramedControlLocation();
parent.layout();
shell.removeListener(SWT.Resize, scaleOnParentResize.get());
});
shell.addListener(SWT.Resize, scaleOnParentResize.get());
if (isDisposed()) {
return;
}
toWrap.pack(true);
setFramedControlLocation();
});

addMouseMoveListener(e -> {
Expand Down
Loading