Revert ImageBasedFrame zoom change listener #3342
Merged
+5
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the change to the zoom changed listener of the ImageBasedFrame. The async DPI change handling of the windows implementation does not need the complex event chaining anymore.
HeikoKlare
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Works fine with (and without): eclipse-platform/eclipse.platform.swt#2520
And of course it's much better to have the logic as simple as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the change to the zoom changed listener of the ImageBasedFrame. The async DPI change handling of the windows implementation does not need the complex event chaining anymore.
It is reverting the changes from 44f830b and 2f6a390 keeping only the disposal check
Is supposed to not cause regressions with eclipse-platform/eclipse.platform.swt#2520