bugfix(module): Consistently yield experience for direct flame kills #1539
+36
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes units and buildings that die via flammable status to consistently yield experience to the flammable status source.
In 1.04, the flammable update damage tick can score the kill on a unit or building and negate any experience that should otherwise have been given to the killer (though this is a lot rarer for flammables as the damage tick is fairly low (usually 5)). This can be seen in the demonstration below, where a Dragon does not gain any experience from destroying a Black Market:
FLAME_NO_XP.mp4
This is a counterpart to #1527 and fixes the same issue but for flame weapons; essentially making experience yields consistent for units directly killed by flame damage weapons. It pretty much exclusively affects the Dragon Tank's primary weapon and does not affect experience yields for flame damage dealt via projectile detonation OCLs such as firewalls or firestorms.