bugfix: Prevent unit attachments being visible through fog after exiting a Tunnel Network

[Stubbjax]

Fixes #29

This change prevents unit attachments from being visible through fog after exiting a Tunnel Network. The tunnel garrison logic goes through a different pathway and does not add the occupants of open containers (e.g. Avenger turrets) to the partition manager on exit. Unfortunately, this change is not retail compatible (though maybe for the best as it would introduce a disadvantage over retail).

See the comparison below:

SHROUD_COMP.mp4

Left client: This change - the blue player cannot see the turret attachment of the green Avenger through the fog ✔️
Right client: Retail build - the green player can see the turret attachment of the blue Avenger through the fog ❌

[Mauller]

I would check if this happens for contained objects being removed from a container in general.

Such as garrisoned structures, vehicles exiting helicopters etc.

Then this likely wants to go into the base remove from contained function call.

[Stubbjax]

I would check if this happens for contained objects being removed from a container in general.

It does indeed via addOrRemoveObjFromWorld.

[Mauller]

I would check if this happens for contained objects being removed from a container in general.

It does indeed via addOrRemoveObjFromWorld.

So does this not happen for affected units with attachments exiting a helicopter in the fog?

[Stubbjax]

I would check if this happens for contained objects being removed from a container in general.

It does indeed via addOrRemoveObjFromWorld.

So does this not happen for affected units with attachments exiting a helicopter in the fog?

Correct, see #29 (comment).

[Mauller]

I wonder if this can be cleaned up just by calling addOrRemoveObjFromWorld(obj, TRUE); ?

[Stubbjax]

That was the way I had originally fixed it before making it more explicit. 😅 I went with this approach because addOrRemoveObjFromWorld(obj, TRUE); calls some of the same logic again, and I thought it might be better if the attachment wasn't added to the pathfinding grid (even though this admittedly adds an inconsistency).

[xezon]

This placement looks suspicious, because there is no counterpart in the TunnelContain::addToContainList function.

The counter part appears to be at

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Contain/OpenContain.cpp

Lines 334 to 342 in 87de0a0

	// Which list to physically add to needs to be overridable
	addToContainList(rider);
	m_playerEnteredMask = rider->getControllingPlayer()->getPlayerMask();
	if (isEnclosingContainerFor( rider ))
	{
	addOrRemoveObjFromWorld(rider, false);
	}

I suggest to revisit.