fix: Include the venv checksum file in the sources fields for all public linting tasks.
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlion
changed the title
venv checksum file in the sources fields for all public linting tasks.
davidlion
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed offline, a task containing both the
sourcesanddepsfields will always execute the tasks listed indeps, but it may skip running itself if thesourcesremain unchanged.To ensure the parent task re-runs whenever the
venvtask is re-executed, we need to enforce this dependency by introducing thevenvtask checksum insources. Otherwise, we risk missing tool version upgrades or inadvertently introducing linting issues.Validation performed
sources, a re-run/ rebuild ofvenvproperly triggers re-runs of all linting tasks.