Skip to content

Conversation

thomas-dufour
Copy link

Checklist:

  • test locally that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@cemsozens
Copy link

@xzkostyan Could you take a look at this PR? It will be really helpful to merge this.

@sk-
Copy link

sk- commented Jun 2, 2025

@xzkostyan is there any chance this PR could be reviewed and released.

The PR looks good, as the changes are the same that were done in the original alembic's PR.

@thomas-dufour
Copy link
Author

@PabloReszczynski thx for the approval. What about merging this PR (I don't know the process in this repo)? Is there anything I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken import due to Alembic removed _reflect_table
4 participants