V3.x #86
Open
V3.x #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 24, 2017 15:54
update to version 2.9.2
* initial changes to support number of days on tile * initial updates to support number of days on tile * changes to support number of days on tile * changes to use Joda-Time library * changes to support TimeDate * DateTime call and numberOfDays tool tip * updated comments
* Changed Tile, set query begin date off end date if provided. * Update synthetic.xml changed numberOfDays to a hidden property. * Update synthetic.xml changed to hidden=true * Changed Tile, default max_days 90, numberOfDays 30 * Changed Tile, default max_days 90, numberOfDays 30 * Changed Tile, default max_days 90, numberOfDays 30 * Changed Tile, maxDays property must have catagory * removed debug
jdewinne
reviewed
Nov 3, 2017
src/main/resources/synthetic.xml
Outdated
| description="Date in format yyyy-MM-dd. If not provided, latest deployed applications are shown."/> | ||
| <property name="maxDays" default="90" category="input" kind="integer" hidden="true"/> | ||
| <property name="numberOfDays" category="input" required="false" default="30" kind="integer" | ||
| description="The number of days worth of (release version) data to reterive from XL Deploy."/> |
There was a problem hiding this comment.
typo: "reterive" --> "retrieve"
|
|
||
| def get_deployed_applications_for_environment(self, environment, date=None): | ||
| archived_tasks = self.query_archived_tasks(date) | ||
| def get_deployed_applications_for_environment(self, environment, begin_date, date=None): |
There was a problem hiding this comment.
Maybe rename last argument from date to end_date
jdewinne
approved these changes
Nov 3, 2017
hierynomus
suggested changes
Nov 30, 2017
|
|
||
| #check the range of values for numberOfDays, | ||
| if not 1 <= numberOfDays <= maxDays: | ||
| numberOfDays = maxDays |
There was a problem hiding this comment.
Can we log something here? So that it's clear in the logs that the data was truncated?
| if xld_client.check_ci_exist(environment): | ||
| if date: | ||
| data = xld_client.get_deployed_applications_for_environment(environment, date) | ||
| #if date provided, set a begin_date based on provided date - number of days |
There was a problem hiding this comment.
There's now quite some duplication between the two branches... Consider refactoring it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging Tile Updates from branch v2.9.x to v3.x. Resolving issue: #82