Feature: custom week number tile content #703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 22, 2022 16:27
…place of week numbers, much like tileContent
|
I tried assigning someone for review and adding some labels but to no avail. I guess it's because I don't have a write permission in the repo. |
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
cef9c7c to
cd7ef12
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
0f9c665 to
88f5da5
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
1f10b65 to
0c5a8da
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
d6fcc20 to
da505dd
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
3407450 to
7fc3da6
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
9045b27 to
22f61e6
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
dc4fd25 to
a8c5ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am developing an app for tracking working hours which was using
react-calendarand I needed to make the area around the week numbers into a customized button with dynamic data. Here's an example of how I use the new feature for that use case:I noticed this related issue #21 that you thought was nice to have, so I hope you approve of my approach. I didn't bother to add the equivalent of
tileClassNameshere since the parent element of the week numbers has the classNamereact-calendar__month-view__weekNumbersand I used that one for styling, but if you think that should be done as well, I could give it a try in this PR or maybe in another.