Use better error formatter for PHPStan

[ruudk]

I would like to propose using a new (and better) error formatter for PHPStan.

Features

• Every error has it's own clickable file + line link (default formatter shows the file once, and then displays the line + errors)
• Errors don't wrap, so they take your while terminal (default formatter wraps in a table)
• Highlighting of variables, fully qualified class names and other common types. This is done naively and there are cases where it does not work.
• Long file paths are truncated visually (src/App/../Entity/User.php) while keeping the clickable link intact
• The filename + line is clickable depending on your terminal and their support for clickable links. For example, in PHPStorm's built-in editor, it doesn't work and there we print file:///Volumes/CS/www/src/App/User.php.

See https://github.com/TicketSwap/phpstan-error-formatter

Curious what you think @spawnia @simPod

[simPod]

Personally I prefer to set these in my phpstan.neon (that includes .dist and overrides individual settings) since other devs may have different preferences.

[ruudk]

It can still be overridden. Good to have a default?

[simPod]

I prefer default defaults 🙃

E.g. on my projects I often output phpstan in github/gitlab CI and the default error format looks better there.
Then, locally I use ticketswap one.

Also for editorUrl, I use IDEA which is phpstorm:// compatible IIRC. Not sure about e.g. vscode though.
By that I wanted to say that it is also specific for each setup. And IMO that's what phpstan.neon is for.

I agree that those options are generally better for most developers. But there may be other environments where they may not make sense so I wanted to point that out.

[mfn]

My 2c:

• I prefer the defaults in CI too, as @simPod said

  default error format looks better there

• personally locally I prefer the raw format:

  Contains one error per line, with path to file, line number, and error description

  Once I discovered this, I knew there was no going back.

  I don't find value in:

  • having an error spawn multiple lines
    when all I need is quickly to read the reason
  • showing the source code
    There's nothing actionable anyway, I need to go to the source directly
    Once side effect of the raw format is that it shows the full path to the file and without ever configuration any terminal (iTerm2, PhpStorm), directly clicking on this and getting my to the file/line "just works ™️".
    No need for anything to configure any subjective editor link anywhere 💪🏼