PR for Issue #417 #418
PR for Issue #417 #418
Conversation
…d consitency changes to us_bmode_linear_transducer.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 46 46
Lines 6744 6744
Branches 1496 1496
=======================================
Hits 4845 4845
Misses 1333 1333
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for this @KR616. Is the implied difference between a bug and an error that a bug is a developer error while an error is a user error? I find the distinction unclear from the naming. Let's clarify the added value of the distinction before merging this in. |
|
I agree. I was unsure how to call this category. How about somethign along the lines of "Help Desk"? |
|
I like help desk. I think we should also make clear the questions should be pointed and specific. We should warn that code dumps of "can you help me here is my code" will be closed without comment. Lastly, we should ask what steps the user has taken thus far to find the answer (e.g. read the documentation, or look at specific examples), and have the user share links to understand their understanding of the problem and encourage them to look for solutions before opening an issue. |
|
|
||
| ## Please note | ||
| <!-- A brief description of what you expected to happen. --> | ||
| - We may ignore any issues due to a lack of time and apologize. |
There was a problem hiding this comment.
Please remove this line. We could rephrase it but removal might be best for now.
| - We may ignore any issues due to a lack of time and apologize. | ||
| - Please first always refer to the [documentation](https://k-wave-python.readthedocs.io/en/latest/index.html), or specific [examples](https://github.com/waltsims/k-wave-python/tree/master/examples) before raising an issue | ||
| - Code dumps "can you help, here is my code" will be closed without comment | ||
| - Be as specific as possible and write in detail what you have already tried, add links and any reference that may help us understand |
There was a problem hiding this comment.
- Add any links and references to resources you have referenced in your problem solving.
| execution_options = SimulationExecutionOptions(is_gpu_simulation=True, verbose_level=2) | ||
| ``` | ||
|
|
||
| ## Environment information |
There was a problem hiding this comment.
Perhaps you can add the commands they can run to get this information? They do this on scipy for example.
There was a problem hiding this comment.
We might be able to query many global variables in kwave.init
|
|
||
| ## Steps to reproduce | ||
| <!-- Step-by-step process to reproduce the behavior --> | ||
| - What script/example did you run? Please provide necessary information. |
There was a problem hiding this comment.
Minimal example to reproduce your issue
[Feature] New issue template for compilation/ executing error
This pull request addresses issue #417
Changes made:
Testing Steps: