Include base64url encoding of extra_client_data in test vectors; regenerate without b64 padding #2346
+89
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
commented
Oct 21, 2025
For consistency with the rest of the spec, which uses base64url without padding.
emlun
changed the title
viralpoetry
reviewed
Oct 21, 2025
This was referenced Oct 29, 2025
selfissued
approved these changes
Oct 29, 2025
timcappalli
approved these changes
Oct 29, 2025
github-actions bot
added a commit
that referenced
this pull request
Oct 29, 2025
SHA: d474f59 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2345.
Preview | Diff