-
-
Couldn't load subscription status.
- Fork 869
refactor[venom]: strengthen an assumption in venom lowering #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor[venom]: strengthen an assumption in venom lowering #4715
Conversation
this commit strengthens an assumption in venom_to_assembly. due to SSA form, the arguments to phi must be in the predecessor blocks. this means that the def does not reach any use from both branches, except in the case that the use is a phi.
phi single use and fix of the simplify cfg pass
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4715 +/- ##
==========================================
+ Coverage 93.00% 93.04% +0.03%
==========================================
Files 131 131
Lines 19095 19167 +72
Branches 3324 3329 +5
==========================================
+ Hits 17760 17834 +74
Misses 898 898
+ Partials 437 435 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reduced the regression
this commit strengthens an assumption in venom_to_assembly. due to SSA form, the arguments to phi must be in the predecessor blocks. this means that the def does not reach any use from both branches, except in the case that the use is a phi.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture