Updates express to zero-config #1204
+79
−64
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import dotenv from 'dotenv'; | ||
| import express, { type Request, type Response } from 'express'; | ||
| import path from 'path'; | ||
| import { fileURLToPath } from 'url'; | ||
|
|
||
| dotenv.config(); | ||
|
|
||
| const app = express(); | ||
|
|
||
| const __filename = fileURLToPath(import.meta.url); | ||
| const rootDir = path.dirname(__filename); | ||
|
|
||
| // Serve static files from the public directory | ||
| app.use(express.static(path.join(rootDir, '..', 'public'))); | ||
|
|
||
| // Home route - HTML | ||
| app.get('/', (req, res) => { | ||
| res.type('html').send(` | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"/> | ||
| <title>Express on Vercel</title> | ||
| <link rel="stylesheet" href="/style.css" /> | ||
| </head> | ||
| <body> | ||
| <nav> | ||
| <a href="/">Home</a> | ||
| <a href="/about">About</a> | ||
| <a href="/api-data">API Data</a> | ||
| <a href="/healthz">Health</a> | ||
| </nav> | ||
| <h1>Welcome to Express on Vercel 🚀</h1> | ||
| <p>This is a minimal example without a database or forms.</p> | ||
| <img src="/images/logo.png" alt="Logo" width="120" /> | ||
| </body> | ||
| </html> | ||
| `); | ||
| }); | ||
|
|
||
|
|
||
| app.get('/about', function (req: Request, res: Response) { | ||
| res.sendFile(path.join(rootDir, '..', 'components', 'about.htm')); | ||
| }); | ||
|
|
||
| // Example API endpoint - JSON | ||
| app.get('/api-data', (req, res) => { | ||
| res.json({ | ||
| message: 'Here is some sample API data', | ||
| items: ['apple', 'banana', 'cherry'] | ||
| }); | ||
| }); | ||
|
|
||
| // Health check | ||
| app.get('/healthz', (req, res) => { | ||
| res.status(200).json({ status: 'ok', timestamp: new Date().toISOString() }); | ||
| }); | ||
|
|
||
| export default app; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "ES2022", | ||
| "module": "NodeNext", | ||
| "moduleResolution": "NodeNext", | ||
| "outDir": "./dist", | ||
| "rootDir": ".", | ||
| "strict": true, | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true | ||
| }, | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start script points to
api/index.tswhich was deleted, but the new entry point issrc/index.ts.View Details
📝 Patch Details
Analysis
The
startscript inpackage.jsonis set to"node api/index.ts", but the fileapi/index.tshas been deleted and replaced withsrc/index.ts. When runningnpm start, this will result in a "Cannot find module" error because the specified file path no longer exists.Additionally, since the project now uses TypeScript with ES modules (
"type": "module"is set), running.tsfiles directly withnodewill not work without compilation or a TypeScript runner liketsxorts-nodewith ES module support.Recommendation
Update the start script to point to the correct file location and use an appropriate TypeScript runner:
Note: You may also need to add a TypeScript runner like
tsxto dev dependencies if you plan to run TypeScript files directly, or add a build step to compile to JavaScript first.