Skip to content

Should be able to schedule any # of minutes <= MAX_WATERING_MINUTES #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Should be able to schedule any # of minutes <= MAX_WATERING_MINUTES #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81f66b1
should be able to request <60 >=0 mins of activity. not just 15 min i…
bdwilson Jun 17, 2020
6445407
should be able to select times outside of 15 min windows, 53 minutes …
bdwilson Jun 17, 2020
ef171e0
should be able to select times outside of 15 min windows, 53 minutes …
bdwilson Jun 17, 2020
8a32378
typo
bdwilson Jun 17, 2020
2c2f060
typo
bdwilson Jun 17, 2020
b74488f
allow untrusted certs
bdwilson Jul 14, 2023
7bee180
allow untrusted certs
bdwilson Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions raincloudy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _authenticate(self):
__location__ = os.path.realpath(
os.path.join(os.getcwd(), os.path.dirname(__file__)))

cert_file = Path(__location__ + "/wifiaquatimer_com_chain.cer")
#cert_file = Path(__location__ + "/wifiaquatimer_com_chain.cer")

# to obtain csrftoken, remove Referer from headers
headers = HEADERS.copy()
Expand All @@ -88,7 +88,7 @@ def _authenticate(self):
# initial GET request
self.client = requests.Session()
self.client.proxies = self._proxies
self.client.verify = cert_file.resolve()
#self.client.verify = cert_file.resolve()
self.client.stream = True
self.client.get(LOGIN_ENDPOINT, headers=headers)

Expand Down
16 changes: 11 additions & 5 deletions raincloudy/faucet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,17 @@ def name(self, value):

def _set_manual_watering_time(self, zoneid, value):
"""Private method to set watering_time per zone."""
if value not in MANUAL_WATERING_ALLOWED:
raise ValueError(
'Valid options are: {}'.format(
', '.join(map(str, MANUAL_WATERING_ALLOWED)))
)
if isinstance(value, str):
if value not in MANUAL_WATERING_ALLOWED:
raise ValueError(
'Valid options are: {}'.format(
', '.join(map(str, MANUAL_WATERING_ALLOWED)))
)
else:
if (value < 0 or value > MAX_WATERING_MINUTES):
raise ValueError(
'Valid options are 0-{}'.format(MANUAL_WATERING_ALLOWED)
)

ddata = self.preupdate()
attr = 'zone{}_select_manual_mode'.format(zoneid)
Expand Down