Skip to content

Conversation

@famouswizard
Copy link

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

turns out the command array was being built too early - before the args were parsed, so it sometimes grabbed junk or ended up empty.

dropped

command=( "${@:2}" )

and now build it after parsing:

command=("$@")

that way it only includes what comes after --, like it should.

also stopped using eval — now it just runs

"${command[@]}"

which is safer and doesn’t break on spaces.

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@cmichi
Copy link
Collaborator

cmichi commented Oct 28, 2025

@famouswizard This changes behavior of the script, which causes the CI to fail. Can you adapt that too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants