fix: command parsing so it actually runs the right thing #2693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contractorpallet-revive?Description
turns out the command array was being built too early - before the args were parsed, so it sometimes grabbed junk or ended up empty.
dropped
command=( "${@:2}" )and now build it after parsing:
command=("$@")that way it only includes what comes after
--, like it should.also stopped using
eval— now it just runs"${command[@]}"which is safer and doesn’t break on spaces.
Checklist before requesting a review
CHANGELOG.md