fix!: extended-splashscreen not working on skia-mobile #1435
+149
−809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoy312
added
the
do-not-merge/work-in-progress
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
2 times, most recently
from
ee3db46 to
816be5c
Compare
Xiaoy312
added
the
do-not-merge/breaking-change
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
from
816be5c to
76fc67e
Compare
Xiaoy312
removed
the
do-not-merge/work-in-progress
Xiaoy312
commented
Aug 15, 2025
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
from
76fc67e to
d5bcf87
Compare
Xiaoy312
removed
the
do-not-merge/breaking-change
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
from
d5bcf87 to
b900150
Compare
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
2 times, most recently
from
faaba19 to
639a6bd
Compare
BREAKING CHANGE: unified ExtendedSplashScreen code across all platforms: - `Platforms` and `SplashIsEnabled` properties has now been removed - On Android, you no longer need to explicitly call `ExtendedSplashScreen.Init`
Xiaoy312
force-pushed
the
dev/xygu/20250804/unified-splashscreen
branch
from
639a6bd to
d0abd2f
Compare
Xiaoy312
added
the
do-not-merge/breaking-change
|
DO NOT MERGE: on hold until we reach an agreement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1404
PR Type
What kind of change does this PR introduce?
(no functional changes, no api changes)What is the current behavior?
ExtendedSplashscreen is not working on skia-mobile.
What is the new behavior?
dropped platform-specific implementations, and moved to a single shared impl.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
depends on: unoplatform/uno.resizetizer#349