feat(abg)!: replace data class perks by code generation in bindings #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
fcb93fe to
f2e6c05
Compare
Vampire
force-pushed
the
vampire/versioned-routes
branch
from
6e0c383 to
05942ab
Compare
This was referenced Sep 8, 2024
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f2e6c05 to
f9bff8a
Compare
Vampire
changed the base branch from
vampire/versioned-routes
to
vampire/binding-version-v2
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
26ff564 to
915be83
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
5b756f4 to
a485fe4
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
915be83 to
01e7a87
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
a485fe4 to
6c58c0d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
01e7a87 to
781eb1b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
6c58c0d to
66b9afd
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
781eb1b to
248813f
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
66b9afd to
f8e466f
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
248813f to
a5da3b1
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
f8e466f to
eb02b5a
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
a5da3b1 to
f58ac6b
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
eb02b5a to
36a0a91
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f58ac6b to
f11c738
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
36a0a91 to
8895541
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f11c738 to
5e87ccb
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
8895541 to
4281b5d
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
5e87ccb to
c89a7e1
Compare
krzema12
reviewed
Oct 17, 2024
| - The `equals` method will work like before. | ||
| - The `hashCode` method will work like before. | ||
| - The `toString` method will work like before. | ||
| - Destructuring assignments are not possible anymore as this will likely break silently or during |
There was a problem hiding this comment.
I initially wanted to ask why this change is made under v2 of the bindings server, and it's probably because of this remark about destructuring. I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
There was a problem hiding this comment.
My plan is to revisit our discussion we had on Slack to ensure that there's no simpler option to achieve what we want. Sometimes ideas come after time 😄
There was a problem hiding this comment.
Let's see if someone has some interesting take on this: https://kotlinlang.slack.com/archives/C8C4JTXR7/p1729233924861659
There was a problem hiding this comment.
I think it's enough to provide component1...componentN functions, then destructuring should work, and we wouldn't have to bump the route version just yet.
It would not be, as said on Slack.
It was intentional I left them out.
And additionally the copy method now also enforces named-arguments which is also a breaking change.
So to replicate here too, the goal here was not to somehow make it compatible with the upcoming Kotlin versions, but to improve the API to the originally intended way.
That this also fixes the copy visibility thing is merely a by-product and just was the trigger to finally have a look at it.
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
4281b5d to
1f9acc7
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
c89a7e1 to
fb71bbb
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
5fdc48f to
4fa6848
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
2 times, most recently
from
53c27b0 to
c9e8a2f
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
bce3f2f to
30806a5
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
c9e8a2f to
d0ef59a
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
30806a5 to
2f28590
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
d0ef59a to
1e38b69
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
2f28590 to
90c380f
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
1e38b69 to
54a0d0e
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
90c380f to
83e3806
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
2 times, most recently
from
0af24c3 to
16cb955
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
2 times, most recently
from
4210942 to
d3ecf79
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
2 times, most recently
from
78db07b to
88a11f6
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
d3ecf79 to
f72df5e
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
88a11f6 to
5b5bb0f
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
f72df5e to
3591e61
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
5b5bb0f to
2974c43
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
3591e61 to
8df1350
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
2974c43 to
481b627
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
8df1350 to
dd21b0f
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
481b627 to
b4d13ce
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
dd21b0f to
1542f03
Compare
Vampire
force-pushed
the
vampire/binding-version-v2
branch
from
b4d13ce to
e788dc0
Compare
Vampire
force-pushed
the
vampire/no-data-bindings
branch
from
1542f03 to
98fc017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629