Skip to content

Conversation

salsina
Copy link

@salsina salsina commented Oct 3, 2025

Added UI option for updating Hugging Face credentials (Issue #703)
When the user provides a new token, we send it to the backend.
The backend clears the cached Hugging Face token (/model/logout_from_huggingface) before saving the new one.

Copy link
Contributor

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Seems like you have a merge conflict with our main branch.
Sorry for being delayed on reviewing this. Will try to review asap once you fix this one so there's no more conflicts.

@salsina
Copy link
Author

salsina commented Oct 7, 2025

Thanks for reviewing. The conflict should be resolved now.

Copy link
Contributor

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you intended this or if its a bug but I see the UI like this which might be confusing to anyone adding the credentials

Image

@salsina
Copy link
Author

salsina commented Oct 7, 2025

Thanks for catching this! I've added an edit button now.
Screenshot 2025-10-07 at 12 51 51 PM

@deep1401
Copy link
Contributor

deep1401 commented Oct 7, 2025

Thanks for catching this! I've added an edit button now.

Screenshot 2025-10-07 at 1 58 39 PM

Not sure why this is happening but I still see it like this. I might just try a clean clone as I'm getting a lot of conflicts pulling currently and report back

Copy link
Contributor

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing a clean clone fixed it and it shows me the two banners only with edit buttons now but clicking on the banner gives this:
Before this I see the settings screen with the banner saying both are set successfully

Image

Please let me know if I'm doing something wrong!

@salsina
Copy link
Author

salsina commented Oct 7, 2025

Could you check if the error is still happening? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants