Changes in github workflow #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RHEL-8 system python is 3.6... I don't think we can drop support for it... |
|
and python 2.6 failures are weird... that stuff should be running on centos 6, ubuntu shouldn't enter the picture... It worked with 2.6 so it should continue to work, if anything, it's the CI environment that is broken, not the code |
|
Okay, thank you, I will investigate Python 2.6 further. About Python 3.6, the Ubuntu 22 image in GitHub does not support it (and is not planning to, according to this discussion). |
|
I think we can use a RHEL image for it, just as we do for 2.6? |
gstarovo
force-pushed
the
ubuntu20-deprecation
branch
from
ad607fc to
ec44ed5
Compare
-ensure working pip on python2.7 -adjust python 3.6 to run on centos:8, since ubuntu22 image does not support python3.6 -git version on centos:6 was too old and was not working properly, changing it to manually download and build newer git version
gstarovo
force-pushed
the
ubuntu20-deprecation
branch
from
ec44ed5 to
c4f0df1
Compare
tomato42
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are several changes in ci.yml to ensure proper functioning.
Reasoning:
The Ubuntu 20.04 Actions runner image is now deprecated in github, so those were changed to the Ubuntu 22.04 image. The merge request as well has changes to ensure working pip on Python 2.7.
Having Python 3.6 in CentOS:8 container:
Python 3.6 is not supported on Ubuntu 22 or newer runners. The change adjusts the tests to be run with Python 3.6 in the CentOS:8 container.
Downloading and building git in centOS:6:
Unit tests failed to run due to the error messages, including ImportError and TypeError. Those can be found in action run .
The problem occurred due to an old version of git provided in CentOS 6. To solve the problem, the changes provide the installation of a newer git version.