-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
style-guide: add argument order suggestion #18006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an example, it's pretty unclear what this is about without context.
One thing I'm having trouble placing is data redirection from a file if the contributor desires to use it. The most logical place would be to put it right after the command so that it points towards the command it's being directed to, like this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the addition. I think the order for data redirection to a file from a file being last is fine, since we follow the same in a majority of our pages for outputting to a file.
@kbdharun You misunderstand. I'm talking about the data redirection from a file not to a file. |
I guess it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant.
I'm looking for feedback on where this might not apply and what else to add to the list.