Skip to content

feat: embedded (finitely generated torsion-free) modules #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: embedded (finitely generated torsion-free) modules #1955

wants to merge 3 commits into from

Conversation

thofma
Copy link
Owner

@thofma thofma commented Aug 22, 2025 •
edited
Loading

Example:

julia> M = Hecke.embedded_module(ZZ, QQ[1 2//3; 3 4]);

julia> N = Hecke.embedded_module(ZZ, QQ[0 1; 0 0]);

julia> intersect(M, N)
Embedded module over Integer ring with generator matrix
[0   -2]
[0    0]

fieker
fieker reviewed Aug 22, 2025
View reviewed changes
src/AlgAssAbsOrd/PicardGroup.jl
@@ -935,7 +935,9 @@ function _intersect_modules(BM::QQMatrix, BN::QQMatrix)
BMint = numerator(d * BM)
BNint = numerator(d * BN)
H = vcat(BMint, BNint)
@info H
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info not vprint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fieker fieker fieker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @fieker