Skip to content

Conversation

@iansamz
Copy link
Contributor

@iansamz iansamz commented Mar 27, 2023

Type of change

  • Documentation change
  • Bug fix

Summary of change

  • GraphQL naming conventions
  • Update README and link to accompanying blog post explaining limitations (Will be updated when blog is ready)
  • Clean up the scripts (yarn start, yarn test etc)
  • Fix linting issues (exclude .yaml files)
  • .env globally available with running queue (optional)

Checklist

@iansamz iansamz requested a review from mbicknese March 27, 2023 12:09
@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 414255a
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/642c3023ddc2af0008473d9c

@mbicknese
Copy link
Contributor

items: entityCollectionPage.items.map(mapTechnology),

Still refers to items

Copy link
Contributor

@mbicknese mbicknese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to work on this branch, but there are more changes required throughout the code to make the new types work. Can you do a sweep to find all outdated code?

@iansamz iansamz self-assigned this Apr 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ihardz ihardz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iansamz , resolve conflicts and merge. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[express-apollo-prisma] Final cleanup from demo feedback

5 participants