-
Couldn't load subscription status.
- Fork 11
added about pic + info #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
added about pic + info #1134
Conversation
WalkthroughAdded a new engineer entry to tcf_website/views/team_info.json by appending Ayan Rasulova to the engineering_team array with specified name, role, class year, image filename, and GitHub handle. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tcf_website/views/team_info.json (1)
127-132: Fix key typo "role:" → "role" (breaks downstream consumers).This object uses "role:" (with a colon in the key) instead of "role", which will likely omit the role in the UI or any code expecting the canonical key.
- { - "name": "Kingsley Kim", - "role:": "Developer", - "class": "2026", - "img_filename": "ENG_Kingsley_Kim.jpg", - "github": "kingsleykimm" - }, + { + "name": "Kingsley Kim", + "role": "Developer", + "class": "2026", + "img_filename": "ENG_Kingsley_Kim.jpg", + "github": "kingsleykimm" + },
🧹 Nitpick comments (1)
tcf_website/views/team_info.json (1)
263-269: Optional: confirm image format/casing conventions and ordering rules.
- Many entries mix .jpg/.JPG/.jpeg/.webp. If the build or CDN is case‑sensitive, standardize extensions to avoid cache misses.
- If the list is intended to be alphabetical or grouped, consider placing the new entry accordingly to minimize future diff churn.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
tcf_website/static/about/team-pfps/ENG_Ayan_Rasulova.jpgis excluded by!**/*.jpg
📒 Files selected for processing (1)
tcf_website/views/team_info.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: pylint
- GitHub Check: django
🔇 Additional comments (1)
tcf_website/views/team_info.json (1)
263-268: LGTM — JSON valid & image present.
jq validated tcf_website/views/team_info.json; image present at static/about/team-pfps/ENG_Ayan_Rasulova.jpg.
GitHub Issues addressed
What I did
i added my picture to team-pfps, and then my info to team_info.json
Screenshots
Testing
Questions/Discussions/Notes
Summary by CodeRabbit