Skip to content

Conversation

ziggornif
Copy link

Hi,

Here's a small fix to resolve the Redis container startup issue with custom commands (#1150).

I noticed a similar issue with the redis-stack image that also overrides this.createOpts.Env.
Would you prefer I include this fix in the same PR, or should I create a separate issue to track it first?

Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 3e6fa91
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/68e39f9105248c000867ba9b
😎 Deploy Preview https://deploy-preview-1155--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco
Copy link
Collaborator

Hi @ziggornif, yes please include the redis-stack command change in this PR

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Oct 6, 2025
Same as redis image with input command

See issue testcontainers#1150
@ziggornif
Copy link
Author

Hi @cristianrgreco, I just made the modification for redis-stack as well. The REDIS_ARGS variable now contains the merge of the user's values with the default values.

I kept the current solution of creating the variable via this.withEnvironment which I recreate with the merge of both values.
We could have also edited the existing variable in this.createOpts.Env. If the current solution works for you, I'll leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Backward compatible bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants