-
-
Notifications
You must be signed in to change notification settings - Fork 580
internal/core: add docker context inspect
to host lookup strategies
#3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmc
wants to merge
2
commits into
testcontainers:main
Choose a base branch
from
tmc:use-docker-context-inspect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−6
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: we have an ongoing PR addressing the docker context support. Although shelling out to the docker CLI is easy, we disregard its usage to avoid handling exit codes, and parsing responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an wild PR my guy! 😂.
The user-facing panic is unfortunate but secondary to not respecting the current docker context. If you have another fix for this incoming I can just close this PR.
I don't completely understand that rationale -- I'd buy not wanting to rely on on a docker binary on PATH but this package has lots of passing on failures if things don't work -- but that's fine you can do what you think is best.
I find layers of complexity on top of test code need to be abundantly clear clear that they are worth the complexity.
Obtaining the current docker host from the current context being more than a 30 line change is a big red flag IMO.
Regardless, I don't really mind how this gets fixed but it impacts me and folks contributing things I'm working on.
So far my experience with this package has driven me to write first a wrapper and then a (IMO) both much smaller, simpler, and better implementation that is much more natively tied into the go testing library. I haven't made it public but it will be at http://github.com/tmc/testctr at some point soon -- it has a (completely optional) testcontainers-go backend implementation.