fix: Throw an exception if the container has exited while checking for readiness

src/Testcontainers/Configurations/WaitStrategies/ContainerException.cs

@@ -0,0 +1,21 @@
+using System;
+using JetBrains.Annotations;
+
+namespace DotNet.Testcontainers.Configurations
+{
+  /// <summary>
+  /// Represents an exception that is thrown when a Docker container fails to start.
+  /// </summary>
+  [PublicAPI]
+  public sealed class ContainerException : Exception
+  {
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ContainerException" /> class.
+    /// </summary>
+    /// <param name="message">The message that describes the error.</param>
+    public ContainerException(string message)
+      : base(message)
+    {
+    }
+  }
+}

src/Testcontainers/Containers/DockerContainer.cs

@@ -5,6 +5,7 @@
   using System.Globalization;
   using System.IO;
   using System.Linq;
+  using System.Text;
   using System.Threading;
   using System.Threading.Tasks;
   using Docker.DotNet;
@@ -674,6 +675,9 @@
       _container = await _client.Container.ByIdAsync(_container.ID, ct)
         .ConfigureAwait(false);
 
+      await ThrowIfExitedAsync(ct)
+        .ConfigureAwait(false);
+
       return await waitStrategy.UntilAsync(this, ct)
         .ConfigureAwait(false);
     }
@@ -699,6 +703,39 @@
       return true;
     }
 
+    private async Task ThrowIfExitedAsync(CancellationToken ct = default)
+    {
+      if (State == TestcontainersStates.Exited)
+      {
+        var message = new StringBuilder($"The {Image.FullName} container has exited.");
+        try
+        {
+          var (stdout, stderr) = await GetLogsAsync(ct: ct)
+            .ConfigureAwait(false);
+
+          stdout = stdout.Trim();
+          stderr = stderr.Trim();
+
+          message.AppendLine();
+
+          if (stderr.Length > 0)
+          {
+            message.AppendLine().AppendLine($"=== stderr of {Name.TrimStart('/')} ({Id}) ===").AppendLine(stderr);
+          }
+
+          if (stdout.Length > 0)
+          {
+            message.AppendLine().AppendLine($"=== stdout of {Name.TrimStart('/')} ({Id}) ===").AppendLine(stdout);
+          }
+        }
+        catch
+        {
+          message.AppendLine(" Please look at the container logs.");
+        }
+        throw new ContainerException(message.ToString());
+      }
+    }
+
     private sealed class WaitUntilPortBindingsMapped : WaitStrategy
     {
       private readonly DockerContainer _parent;

tests/Testcontainers.Platform.Linux.Tests/DependsOnTest.cs

@@ -19,11 +19,13 @@ public async ValueTask InitializeAsync()
     {
         var childContainer1 = new ContainerBuilder()
             .WithImage(CommonImages.Alpine)
+            .WithEntrypoint(CommonCommands.SleepInfinity)
             .WithLabel(_labelKey, _labelValue)
             .Build();
 
         var childContainer2 = new ContainerBuilder()
             .WithImage(CommonImages.Alpine)
+            .WithEntrypoint(CommonCommands.SleepInfinity)
             .WithLabel(_labelKey, _labelValue)
             .Build();
 
@@ -41,6 +43,7 @@ public async ValueTask InitializeAsync()
             .DependsOn(network)
             .DependsOn(volume, "/workdir")
             .WithImage(CommonImages.Alpine)
+            .WithEntrypoint(CommonCommands.SleepInfinity)
             .WithLabel(_labelKey, _labelValue)
             .Build();
 

tests/Testcontainers.Platform.Linux.Tests/PortForwardingTest.cs

@@ -51,7 +51,6 @@ public PortForwardingDefaultConfiguration(HostedService fixture)
                 .WithAutoRemove(false)
                 .WithEntrypoint("nc")
                 .WithCommand(HostedService.Host, fixture.Port.ToString(CultureInfo.InvariantCulture))
-                .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(new WaitUntil()))
                 .Build())
         {
         }
@@ -67,7 +66,6 @@ public PortForwardingNetworkConfiguration(HostedService fixture)
                 .WithEntrypoint("nc")
                 .WithCommand(HostedService.Host, fixture.Port.ToString(CultureInfo.InvariantCulture))
                 .WithNetwork(new NetworkBuilder().Build())
-                .WithWaitStrategy(Wait.ForUnixContainer().AddCustomWaitStrategy(new WaitUntil()))
                 .Build())
         {
         }
@@ -115,12 +113,4 @@ private async Task AcceptSocketAsync()
                 .ConfigureAwait(false);
         }
     }
-
-    private sealed class WaitUntil : IWaitUntil
-    {
-        public Task<bool> UntilAsync(IContainer container)
-        {
-            return Task.FromResult(TestcontainersStates.Exited.Equals(container.State));
-        }
-    }
 }

tests/Testcontainers.Tests/Unit/Containers/Unix/TestcontainersContainerTest.cs

@@ -293,6 +293,7 @@ public async Task DockerEndpoint()
         await using var container = new ContainerBuilder()
           .WithDockerEndpoint(TestcontainersSettings.OS.DockerEndpointAuthConfig)
           .WithImage(CommonImages.Alpine)
+          .WithEntrypoint(CommonCommands.SleepInfinity)
           .Build();
 
         // When