Addition tests with snapshots #3170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new test to exercise addition arithmetic of Durations to PlainDates, with snapshotting. The "interesting" dates are the same as in test/thorough/datedifference.mjs. We add a new list of "interesting" durations for use in this and following tests. They are annotated with comments explaining why they are included. Some improvements to the support file: refactor the creation of the "interesting" dates into a makeDateCases() function, and also add a facility to match a snapshot of the result of a function call that may also legitimately throw a RangeError.
Similar to the previous commit, combining the "interesting" datetimes from test/thorough/datetimedifference.mjs with the "interesting" durations.
Similar to the previous commit, combining the "interesting" epoch nanoseconds from test/thorough/instantdifference.mjs with the "interesting" durations.
Similar to the previous commit, combining the "interesting" times from test/thorough/timedifference.mjs with the "interesting" durations.
Similar to the previous commit, combining the "interesting" year-months from test/thorough/yearmonthdifference.mjs with the "interesting" durations.
Similar to the previous commit, combining the "interesting" ZonedDateTimes from test/thorough/zoneddifference.mjs with the "interesting" durations.
Combining the "interesting" durations with each other in addition and subtraction. We need to filter out durations with calendar units for this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3170 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 22 22
Lines 10209 10209
Branches 1839 1839
=======================================
Hits 9894 9894
Misses 266 266
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3164, adds tests with many combinations of inputs for addition and subtraction on all Temporal types. Some deduplication of code into the support.mjs file, and a new list of "interesting" Durations.