Editorial: Fix some type assertions #3167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
utc-offset-limits
branch
from
e45bfd9 to
24143bc
Compare
aria-eide
reviewed
Oct 23, 2025
This Record was previously anonymous. Introduce it as a specific Record type in order to clarify the limits of the [[OffsetMinutes]] field and that the two fields are mutually exclusive. Since this type information is considered to be equivalent to assertions, this allows removing some assertions and some descriptive text from elsewhere. Credit to Vebjørn Øiestad for discovering this. Co-Authored-By: Vebjørn Øiestad <102312685+voiestad@users.noreply.github.com>
This should allow implementors to more easily pick the width of the integer type used to represent these quantities. Credit to Vebjørn Øiestad for discovering this. Co-Authored-By: Vebjørn Øiestad <102312685+voiestad@users.noreply.github.com>
We have similar language in ISO Date-Time Record.
This field is not ≥ 0, as can be trivially verified by calling AddTime with any Time Record and a time duration < -86400,000,000,000. Credit to Vebjørn Øiestad and Aria Bjørnbakken Eide for discovering this. Co-Authored-By: Vebjørn Øiestad <102312685+voiestad@users.noreply.github.com> Co-Authored-By: Aria Bjørnbakken Eide <179501967+aria-eide@users.noreply.github.com>
ptomato
force-pushed
the
utc-offset-limits
branch
from
24143bc to
b203fc9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 22 22
Lines 10209 10209
Branches 1839 1839
=======================================
Hits 9894 9894
Misses 266 266
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A group at the University of Bergen has done some work using an automated proof assistant on the type assertions in the spec text, and brought several issues to my attention. This PR fixes those issues.
The proof code is available at https://github.com/bldl/temporal-rocq
I recommend reviewing each commit separately.
Summary of the changes:
Thank you to @voiestad and @aria-eide.