Skip to content

Allow 'auto' to be passed as a height #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow 'auto' to be passed as a height #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/swimlane/ngx-datatable/src/lib/components/datatable.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,13 @@ export class DatatableComponent implements OnInit, DoCheck, AfterViewInit {
* The minimum header height in pixels.
* Pass a falsey for no header
*/
@Input() headerHeight: number = 30;
@Input() headerHeight: number | 'auto' = 30;

/**
* The minimum footer height in pixels.
* Pass falsey for no footer
*/
@Input() footerHeight: number = 0;
@Input() footerHeight: number | 'auto' = 0;

/**
* If the table should use external paging
Expand Down Expand Up @@ -851,8 +851,8 @@ export class DatatableComponent implements OnInit, DoCheck, AfterViewInit {

if (this.scrollbarV) {
let height = dims.height;
if (this.headerHeight) height = height - this.headerHeight;
if (this.footerHeight) height = height - this.footerHeight;
if (this.headerHeight) height = height - (this.headerHeight as number);
if (this.footerHeight) height = height - (this.footerHeight as number);
this.bodyHeight = height;
}

Expand Down
2 changes: 1 addition & 1 deletion projects/swimlane/ngx-datatable/src/lib/components/footer/footer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import { DatatableFooterDirective } from './footer.directive';
changeDetection: ChangeDetectionStrategy.OnPush
})
export class DataTableFooterComponent {
@Input() footerHeight: number;
@Input() footerHeight: number | 'auto';
@Input() rowCount: number;
@Input() pageSize: number;
@Input() offset: number;
Expand Down