chore(plugins): define version in pyproject for openai/mongodb/sql; read __version__ via importlib.metadata (#2722) #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.toml and read via importlib.metadata\n\n- Set explicit version in pyproject.toml for openai, mongodb, sql\n- Remove [tool.setuptools.dynamic] version mapping\n- __init__: derive __version__ from installed distribution\n\nRefs: superduper-io#2722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Move plugin version to [project].version in pyproject.toml for: openai, mongodb, sql.
• Remove [tool.setuptools.dynamic] version mapping.
• In package init.py, derive version from installed distribution via importlib.metadata (fallback to 0.0.0 if not installed).
Why
Per #2722, modern packaging recommends declaring version in pyproject.toml rather than init.py. This change aligns plugins with the main project and simplifies packaging.
Notes
• No runtime behavior changes expected.
• Kept version available for importers.
• Tested locally: packages install/editable and import version resolves from distribution.
Follow-ups
• Apply the same change across remaining plugins once this approach is approved.
Refs: #2722