feat(WebAuthn): add an option for user verification #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow configuring the user verification requirement. This is implemented as a boolean that is translated into either UserVerificationRequirement "required" or "discouraged". Do not default to "preferred" since its behaviour is confusing at best. Fixes strangerlabs#21
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 12.66% 12.53% -0.13%
==========================================
Files 5 5
Lines 387 391 +4
==========================================
Hits 49 49
- Misses 338 342 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring the user verification requirement. This is implemented
as a boolean that is translated into either
UserVerificationRequirement"required" or "discouraged". Do not default to "preferred" since its
behaviour is confusing at best.
Fixes #21