- 
                Notifications
    You must be signed in to change notification settings 
- Fork 22
Add manual workflow to deploy docker images to blockstack #285
base: main
Are you sure you want to change the base?
Conversation
| How would this play out locally if we pull some changes, try spinning up devenv and the images are not built yet in the CI? | 
| It would play out poorly - you would need to run  It might be worth making a separate  | 
42beb8a    to
    799a66d      
    Compare
  
    1be5589    to
    fe36b57      
    Compare
  
    | password: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v5 | ||
| if: ${{ matrix.service }} == sbtc | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is sbtc not in the matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sBTC is above, because it's built with the sources here I put it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question as @CAGS295  - is there a reason sbtc can't be added to this matrix that i'm not seeing here?
the build step looks compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if: ${{ matrix.service }} != sbtc No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the check means to only run if it is not sbtc. Otherwise, I don't understand the purpose of the if condition.
b5fddb8    to
    a906eec      
    Compare
  
    | Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   41.03%   42.70%   +1.66%     
==========================================
  Files          40       45       +5     
  Lines        5042     5290     +248     
  Branches        0       47      +47     
==========================================
+ Hits         2069     2259     +190     
- Misses       2973     3030      +57     
- Partials        0        1       +1     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. | 
| platform: amd64 | ||
|  | ||
| push_services_to_registry: | ||
| strategy: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| strategy: | |
| strategy: | |
| fail-fast: false | |
| max-parallel: 4 # or 8,10 etc | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes that might be good to make, but the workflow isn't complicated so I'll approve it. suggested changes/questions are not blockers
| Is this good to merge? | 
| @AshtonStephens This is still helpful for devenv when using nakamoto. Can we have docker images for the current state of stacks-blockchain node? | 
Summary of Changes
Add manual docker image publishing
Testing
Risks
Few risks. It could provide faulty images and make people believe their code is broken when it's just the images.
How were these changes tested?
Tested on an x86 computer. Has issues with ARM64
What future testing should occur?
Should find a way to generate arm64 images.
Checklist: