Skip to content

Feat/add persent encode option #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feat/add persent encode option #43

wants to merge 5 commits into from

Conversation

takao-h
Copy link
Contributor

@takao-h takao-h commented Jan 31, 2025

Summary

percent-encoding option implemented

@takao-h takao-h requested a review from ssssota January 31, 2025 10:03
ssssota
ssssota reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@ssssota ssssota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本的には落ちるテストを書いて、それに対して動くように実装を修正するというサイクルを取るといいです
（要はTDD）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssssota ssssota ssssota left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takao-h @ssssota