Skip to content

feat: pass tempdir to EnvBase #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

feat: pass tempdir to EnvBase #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0514347
feat: pass tempdir to EnvBase
johanneskoester Mar 13, 2025
09f7198
adapt test suite
johanneskoester Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions snakemake_interface_software_deployment_plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,15 @@ def __init__(
within: Optional["EnvBase"],
settings: Optional[SoftwareDeploymentSettingsBase],
shell_executable: str,
tempdir: Path,
deployment_prefix: Optional[Path] = None,
archive_prefix: Optional[Path] = None,
):
self.spec: EnvSpecBase = spec
self.within: Optional["EnvBase"] = within
self.settings: Optional[SoftwareDeploymentSettingsBase] = settings
self.shell_executable: str = shell_executable
self.tempdir = tempdir
self._managed_hash_store: Optional[str] = None
self._managed_deployment_hash_store: Optional[str] = None
self._obj_hash: Optional[int] = None
Expand Down
6 changes: 5 additions & 1 deletion snakemake_interface_software_deployment_plugins/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from abc import ABC, abstractmethod
import asyncio
from copy import deepcopy
import tempfile
from typing import Optional, Type
import subprocess as sp

Expand Down Expand Up @@ -118,7 +119,10 @@ def _get_cached_env_spec(self):
def _get_env(self, tmp_path) -> EnvBase:
env_cls = self.get_env_cls()
spec = self._get_cached_env_spec()
args = {"settings": self.get_software_deployment_provider_settings()}
args = {
"settings": self.get_software_deployment_provider_settings(),
"tempdir": tempfile.gettempdir(),
}
if issubclass(env_cls, DeployableEnvBase):
args["deployment_prefix"] = tmp_path / "deployments"
if issubclass(env_cls, ArchiveableEnvBase):
Expand Down