Skip to content

Conversation

@rachitchadha
Copy link

Add a disclaimer at top of this notebook that Umbrella repo containing IET and neural-chat (ITREX) has been discontinued

Summary

[Provide a short and descriptive summary of the pull request, e.g., "Improve caching mechanism for API calls"]

Type of Change (Mandatory)

Specify the type of change being made.

  • Feature enhancement
  • Bug fix
  • Documentation update
  • Security improvement
  • Others [Please specify]

Description (Mandatory)

[Explain the goal of this PR, the problem it solves and a summary of changes made. Reference any related issues or tickets (e.g., Fixes #123).]

Testing

[Describe the testing done for this PR. If applicable include screenshots.]

…inues. add a disclaimer at top of this notebook
"# ⚠️ Disclaimer\n",
"\n",
"**ITREX 🛑 Discontinued** \n",
"This experiment has been discontinued. ITREX repository serves as an umbrella for IET(Intel Extension For Transformers) and neural-chat is no longer actively maintained."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to re-word this slightly:

This experiment is now deprecated. The ITREX repository, which serves as an umbrella for IET(Intel Extension For Transformers) and neural-chat, is no longer actively maintained.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, "ITREX" is the Intel Extension Transformers (the acronym is basically Intel Transformers Extension), so I would further simplify and reword it to:

This experiment is now deprecated. The ITREX (Intel(R) Extension For Transformers) repository is no longer actively maintained.

@teoparvanov
Copy link
Collaborator

teoparvanov commented May 22, 2025

Please sign your commits by running git commit -s -m "...". This will fix the DCO verification failure in the PR pipeline.

@psfoley
Copy link
Contributor

psfoley commented May 22, 2025

If ITREX / Neuralchat libraries are archived, they should be removed from the example. From looking through the notebook I expect it's straightforward to swap in other Huggingface libraries here, but I'll defer to @kta-intel if he has a different recommendation as this is his original example

@kminhta
Copy link
Collaborator

kminhta commented May 23, 2025

If ITREX / Neuralchat libraries are archived, they should be removed from the example. From looking through the notebook I expect it's straightforward to swap in other Huggingface libraries here, but I'll defer to @kta-intel if he has a different recommendation as this is his original example

Yeah, it should be fairly straightforward to swap ITREX calls with HF Transformer calls, but I actually recommend we remove this example entirely. As it stands, without the ITREX components (which I agree should be removed since they are archived), this example won't add any unique functionalities from the phi-4 fine-tuning example

WDYT? @teoparvanov @rachitchadha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants