Skip to content

Conversation

@R-Palazzo
Copy link
Contributor

Resolve #449
CU-86b72ragn

@R-Palazzo R-Palazzo self-assigned this Oct 20, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner October 20, 2025 12:32
@sdv-team
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.94%. Comparing base (20e32eb) to head (3c033e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   71.90%   71.94%   +0.03%     
==========================================
  Files          27       27              
  Lines        2168     2171       +3     
==========================================
+ Hits         1559     1562       +3     
  Misses        609      609              
Flag Coverage Δ
integration 56.57% <100.00%> (+0.06%) ⬆️
unit 65.96% <100.00%> (+3.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +37 to +42
warnings.filterwarnings(
'ignore',
message='.*is incompatible with transformer.*',
category=UserWarning,
)
hyper_transformer.update_sdtypes(config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the actual cause of the warnings? Could we change the logic at all to just prevent them instead of filtering them out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrew,

The issue occurs because we first call hyper_transformer.detect_initial_config(real_data) and then update the configuration to match the metadata sdtypes. Sometimes, detect_initial_config assigns transformers that aren’t compatible with the updated sdtypes.

For example, a datetime column stored as an object might be detected as categorical and assigned the UniformEncoder. Later, when we update the sdtype to datetime, the configuration becomes invalid since UniformEncoder doesn’t support datetime sdtypes — which triggers the warning.

Instead of filtering out the warning, I decided to update the transformer assignment whenever the sdtype changes. This preserves the previous behavior while avoiding the warning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I understand the warning I think it's better to just go back to silencing it 😅 . The reason being that I think it's better to use the methods RDT exposes in the docs than directly changing field_transformers

@R-Palazzo R-Palazzo requested a review from amontanez24 October 21, 2025 12:10
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is annoying, but can you change it back to how you had it before?

@R-Palazzo R-Palazzo force-pushed the issue-449-userwarning-uniformsynthesizer branch from 4a65969 to 44eb234 Compare October 22, 2025 11:37
@R-Palazzo R-Palazzo requested a review from amontanez24 October 22, 2025 11:37
@R-Palazzo R-Palazzo force-pushed the issue-449-userwarning-uniformsynthesizer branch from 44eb234 to 3c033e8 Compare October 22, 2025 16:26
@R-Palazzo R-Palazzo merged commit 12e1a80 into main Oct 23, 2025
55 checks passed
@R-Palazzo R-Palazzo deleted the issue-449-userwarning-uniformsynthesizer branch October 23, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The UniformSynthesizer produces multiple UserWarning messages when run on a demo dataset

4 participants