Skip to content

Conversation

@Bios-Marcel
Copy link
Member

@Bios-Marcel Bios-Marcel commented Jan 5, 2025

TODO

  • Introduce optional encryption

    Forcing this might break existing deployments and a default secret for encryption would useless.
    Generating a secret based on machine details, such as a MAC Address might be unreliable in
    a world with ephemeral VMs and Docker containers.

  • Don't accept new connections during shutdown
  • Write unit tests
    • UserSession Changes
      • GetPlayer
      • kickPlayer
    • Resurrect
      • Make sure the lobby is fully functional, simulate gameflow with real sockets

An issue I encountered is, that the current implementation becomes useless once a user manually pressed F5. To solve this, a custom lobby gone page is required OR the lobby needs to be able to show even for an empty lobby.

The latter would be more consistent UI wise. But this means that upon resurrection, the lobby needs to reload, as some of the templated state won't be available.

Fixes #371

@Bios-Marcel Bios-Marcel force-pushed the restart_lobby_resurrection branch from 36fe9f6 to 6a110da Compare March 16, 2025 17:19
@Bios-Marcel Bios-Marcel force-pushed the restart_lobby_resurrection branch from 6a110da to c28fb6f Compare March 16, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ephemeral state should survive restart

1 participant