Fix CNF and DNF transformations #128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now CNF and DNF formulas can contain quantifiers, followed by a matrix that is in a normal form. Any PNF can be converted to a CNF and DNF without Skolemization. CNFClauseSet and DNFClauseSet are replacing the old CNF and DNF for a quantifier-free representation, obtained after Skolemization.
CNF -> Cnf DNF -> Dnf FOF -> Fof SNF -> Snf PNF -> Pnf PCF -> Pcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNF and DNF data structures now support quantifiers (universal and existential), followed by a matrix in normal form.
This allows for converting to CNF/DNF without Skolemization, which is needed for implementing certain transformation algorithms to GNF (will be implemented next). Now, any formula in PNF can be converted to CNF/DNF.
New types
CnfClauseSetandDnfClauseSetare replacing the old structuresCnfandDnf, accompanied with new traitsToCnfClauseSetandToDnfClauseSet, which is used to convert a formula that is already inSnf.Minor refactoring includes: applying clippy suggestions and renaming formula types to ones that are idiomatic in rust (e.g.,
CNF->Cnf,FOF->Fof, etc.).