Fully implemented 3D Model Import (Mixed Reality Lab 2022/23) #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a local reference to janves folder to the correct github folder
…a into OptiCoffee/direct-link
…/VIAProMa into OptiCoffee/direct-link
…/VIAProMa into OptiCoffee/direct-link
The camera should now keep the object in frame more reliably.
And subsequent thumbnail position
Implemented a WHOLE lot of stuff. File Browser works now and allows to delete files. When this is done, the session and search browser don't refresh - they only refresh, when the deleted item is downloaded or reimported again, and then refresh all other items from the same source. To do this was completely bonkers and also required to add a txt for every glb that saves the according webLink. IMPORTANT NOTE: we have to implement, that when leaving a session or entering one, lonesome pngs without GLBs are deleted. These are not deleted when a file is deleted, as they can be used within the session browser for objects, that are in the session, but have been recently deleted from the file browser.
Hotfix for aborted downloads, sessionbrowser is now refreshed correctly
Fully implemented browser with sketchfab funtionality and sync + save
IRoomingI
added
enhancement
Redownloaded items from the session browser now don't update all other objects in the session that have the same webLink anymore, as this function is currently broken. However, this function isn't needed ever anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge the final implementation of the 3D Model Import feature to the VIAProMa develop-branch.